Skip to content

Conversation

@rupertj
Copy link
Contributor

@rupertj rupertj commented Jul 16, 2025

Fix for #733 and #767.

This PR stops Image XObjects being included in the results of PDFObject:: getTextArray() as empty strings.

@k00ni
Copy link
Collaborator

k00ni commented Jul 17, 2025

Thank you for your PR.

Is it still work in progress?

If not, there are a few tasks left to solve before I take a closer look. Please read https://github.com/smalot/pdfparser/blob/master/CONTRIBUTING.md for more information.

@rupertj
Copy link
Contributor Author

rupertj commented Jul 17, 2025

Thanks for pointing me to that @k00ni. I've fixed the code style issues and added test coverage for the change.

I think this is ready to be reviewed.

@k00ni
Copy link
Collaborator

k00ni commented Jul 25, 2025

The PR looks good.

I was wondering why it didn't show any CI test results, but found that Github doesn't support Windows 2019 anymore in the workflows (actions/runner-images#12045 (comment)).

#776 should solve that. After it was merged into master, I can give you a hint so you can merge it. Afterwards we should see if the CI has any complains.

@k00ni k00ni added the fix label Jul 25, 2025
@k00ni
Copy link
Collaborator

k00ni commented Jul 29, 2025

Please merge in the current master branch to trigger our CI.

@rupertj
Copy link
Contributor Author

rupertj commented Jul 29, 2025

Thanks @k00ni - I've done that now. Could you approve the CI run please?

@k00ni
Copy link
Collaborator

k00ni commented Jul 29, 2025

This PR is good to go, but I wanna make sure we are not closing issues by accident. That's why I asked there for some feedback.

@k00ni k00ni self-assigned this Jul 29, 2025
@k00ni k00ni merged commit 98d31ba into smalot:master Jul 31, 2025
32 checks passed
@daniser
Copy link

daniser commented Sep 10, 2025

Do this PR also close #761?

@k00ni
Copy link
Collaborator

k00ni commented Nov 4, 2025

Do this PR also close #761?

It should, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getDataTm() missing content getDataTm() provides wrong coordinates for text blocks

3 participants