-
Notifications
You must be signed in to change notification settings - Fork 569
Stop Image XObjects being included as empty strings in PDFObject::getTextArray(). #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your PR. Is it still work in progress? If not, there are a few tasks left to solve before I take a closer look. Please read https://github.com/smalot/pdfparser/blob/master/CONTRIBUTING.md for more information. |
|
Thanks for pointing me to that @k00ni. I've fixed the code style issues and added test coverage for the change. I think this is ready to be reviewed. |
|
The PR looks good. I was wondering why it didn't show any CI test results, but found that Github doesn't support Windows 2019 anymore in the workflows (actions/runner-images#12045 (comment)). #776 should solve that. After it was merged into master, I can give you a hint so you can merge it. Afterwards we should see if the CI has any complains. |
|
Please merge in the current master branch to trigger our CI. |
|
Thanks @k00ni - I've done that now. Could you approve the CI run please? |
|
This PR is good to go, but I wanna make sure we are not closing issues by accident. That's why I asked there for some feedback. |
|
Do this PR also close #761? |
It should, yes. |
Fix for #733 and #767.
This PR stops Image XObjects being included in the results of PDFObject:: getTextArray() as empty strings.