Skip to content

Conversation

@pkcll
Copy link
Contributor

@pkcll pkcll commented Aug 20, 2025

loop/server: wire up ChipIngressInsecureConnection option

Why?

ChipIngress should use TLS by default, while Beholder does not use TLS for local connection to sidecar collector by default.

Related PR #1374 cc @krehermann @Tofel

Testing

Companion PR smartcontractkit/chainlink#18947
Was tested on staging on cl-keystone-one

@github-actions
Copy link

github-actions bot commented Aug 20, 2025

apidiff results - no incompatible changes detected ✅

Module: github-com-smartcontractkit-chainlink-common

Status: ✅ 1 compatible changes

(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17108988323/#summary-48525301974)

@pkcll pkcll requested a review from patrickhuie19 August 20, 2025 19:48
@pkcll pkcll marked this pull request as ready for review August 20, 2025 19:48
@pkcll pkcll requested a review from a team as a code owner August 20, 2025 19:48
@pkcll pkcll requested review from Tofel and krehermann August 20, 2025 19:55

envChipIngressEndpoint = "CL_CHIP_INGRESS_ENDPOINT"
envChipIngressEndpoint = "CL_CHIP_INGRESS_ENDPOINT"
envChipIngressInsecureConnection = "CL_CHIP_INGRESS_INSECURE_CONNECTION"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a variety of config parameters like this now (TLS or local mode), and I think some are formatted as secure while others are formatted as insecure. insecure is probably the way to go, so no action here.

Copy link
Contributor

@krehermann krehermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break the local env. please update all the relevant tomls like

https://github.com/smartcontractkit/chainlink/blob/cec7743de3e74839ce92f236146ce9e320a4a076/core/scripts/cre/environment/configs/workflow-don.toml#L74

ie review all the toml artifacts in that dir and add your new config val as appropriate

@pkcll
Copy link
Contributor Author

pkcll commented Aug 20, 2025

this will break the local env. please update all the relevant tomls like

https://github.com/smartcontractkit/chainlink/blob/cec7743de3e74839ce92f236146ce9e320a4a076/core/scripts/cre/environment/configs/workflow-don.toml#L74

ie review all the toml artifacts in that dir and add your new config val as appropriate

@krehermann, pease see the note in the PR description "Companion PR smartcontractkit/chainlink#18947"
I believe Its done there.

@krehermann krehermann merged commit 59b148e into main Aug 21, 2025
19 of 21 checks passed
@krehermann krehermann deleted the INFOPLAT-2627-chip-ingress-config-insecure-connection branch August 21, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants