-
Notifications
You must be signed in to change notification settings - Fork 25
loop/server: wire up ChipIngressInsecureConnection option #1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loop/server: wire up ChipIngressInsecureConnection option #1495
Conversation
apidiff results - no incompatible changes detected ✅Module:
|
|
|
||
| envChipIngressEndpoint = "CL_CHIP_INGRESS_ENDPOINT" | ||
| envChipIngressEndpoint = "CL_CHIP_INGRESS_ENDPOINT" | ||
| envChipIngressInsecureConnection = "CL_CHIP_INGRESS_INSECURE_CONNECTION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a variety of config parameters like this now (TLS or local mode), and I think some are formatted as secure while others are formatted as insecure. insecure is probably the way to go, so no action here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will break the local env. please update all the relevant tomls like
ie review all the toml artifacts in that dir and add your new config val as appropriate
@krehermann, pease see the note in the PR description "Companion PR smartcontractkit/chainlink#18947" |
loop/server: wire up ChipIngressInsecureConnection option
Why?
ChipIngress should use TLS by default, while Beholder does not use TLS for local connection to sidecar collector by default.
Related PR #1374 cc @krehermann @Tofel
Testing
Companion PR smartcontractkit/chainlink#18947
Was tested on staging on cl-keystone-one