Skip to content

Conversation

@jmank88
Copy link
Contributor

@jmank88 jmank88 commented Aug 21, 2025

@jmank88 jmank88 requested a review from a team as a code owner August 21, 2025 00:19
@github-actions
Copy link

👋 jmank88, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link

github-actions bot commented Aug 21, 2025

apidiff results - no incompatible changes detected ✅

Module: github-com-smartcontractkit-chainlink-common

Status: ✅ 2 compatible changes

(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17139405929/#summary-48623295525)

vyzaldysanchez
vyzaldysanchez previously approved these changes Aug 21, 2025
l.ok = false
}

type LazyLoadCtx[T any] struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func comments please. i don't really understand the intention or use case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot to link the ton PR that uses this. It is just a variant of LazyLoad that yields to context cancellation.
Solana has one here: https://github.com/smartcontractkit/chainlink-solana/blob/develop/pkg/solana/utils/loader.go

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added more docs

@jmank88 jmank88 merged commit 49b2298 into main Aug 21, 2025
19 of 21 checks passed
@jmank88 jmank88 deleted the lazyloadctx branch August 21, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants