Skip to content

Experimental LOOPP-enabling adjustment to MaxDurationQuery #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmank88 wants to merge 1 commit into from
Closed

Experimental LOOPP-enabling adjustment to MaxDurationQuery #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion offchainreporting2plus/internal/ocr2/protocol/report_generation_leader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,13 @@ func (repgen *reportGenerationState) startRound() {
repgen.leaderState.readyToStartRound = false
var query types.Query
{
ctx, cancel := context.WithTimeout(repgen.ctx, repgen.config.MaxDurationQuery)
maxDurationQuery := repgen.config.MaxDurationQuery
if maxDurationQuery == 0 {
// Some feeds are configured to zero due to the in-memory implementation of Query being a no-op.
// This is incompatible with GRPC/LOOPPs, which short circuits on the cancelled context, so we override the value.
maxDurationQuery = 20 * time.Millisecond // TODO from config?
}
ctx, cancel := context.WithTimeout(repgen.ctx, maxDurationQuery)
defer cancel()

ins := loghelper.NewIfNotStopped(
Expand Down