-
Notifications
You must be signed in to change notification settings - Fork 0
feat: make error handling of cache tags providers configurable #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
253eef4
feat: make error handling of cache tags providers configurable
mfeltscher 14affdd
fix: adjust default
mfeltscher 9492d84
Apply suggestions from code review
mfeltscher 816af16
erroooooor
mfeltscher d75b4be
errorrrrrs
mfeltscher bf0e7c8
fix: guard onError callback to prevent masking provider errors (#218)
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import type { CacheTag, CacheTagsProvider, CacheTagsProviderErrorHandlingConfig } from '../types.js'; | ||
|
|
||
| /** | ||
| * An abstract base class for `CacheTagsProvider` implementations that adds error handling and logging. | ||
| */ | ||
| export abstract class AbstractErrorHandlingCacheTagsProvider implements CacheTagsProvider { | ||
| protected readonly throwOnError: boolean; | ||
| protected readonly onError?: CacheTagsProviderErrorHandlingConfig['onError']; | ||
|
|
||
| protected constructor( | ||
| protected readonly providerName: string, | ||
| config: CacheTagsProviderErrorHandlingConfig = {}, | ||
| ) { | ||
| this.throwOnError = config.throwOnError ?? true; | ||
| this.onError = config.onError; | ||
| } | ||
|
|
||
| public abstract storeQueryCacheTags(queryId: string, cacheTags: CacheTag[]): Promise<void>; | ||
|
|
||
| public abstract queriesReferencingCacheTags(cacheTags: CacheTag[]): Promise<string[]>; | ||
|
|
||
| public abstract deleteCacheTags(cacheTags: CacheTag[]): Promise<number>; | ||
|
|
||
| public abstract truncateCacheTags(): Promise<number>; | ||
|
|
||
| protected async wrap<T>(method: keyof CacheTagsProvider, args: unknown[], fn: () => Promise<T>, fallback: T): Promise<T> { | ||
| try { | ||
| return await fn(); | ||
| } catch (error) { | ||
| const provider = this.providerName; | ||
|
|
||
| // Call onError callback if provided, but guard against exceptions | ||
| // to prevent masking the original provider error | ||
| try { | ||
| this.onError?.(error, { provider, method, args }); | ||
| } catch (handlerError) { | ||
| console.error(`Error handler itself failed in ${provider}.${method}.`, { handlerError }); | ||
| } | ||
|
|
||
| if (this.throwOnError) { | ||
| throw error; | ||
| } | ||
| console.debug(`Error occurred in ${provider}.${method}.`, { error, args }); | ||
mfeltscher marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| return fallback; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.