Skip to content

fix: guard onError callback to prevent masking provider errors #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeltscher merged 3 commits into from
Feb 16, 2026
Merged

fix: guard onError callback to prevent masking provider errors #218

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13ac2bb
Initial plan
Copilot Feb 16, 2026
a765576
fix: wrap onError callback in try-catch to prevent masking original e…
Copilot Feb 16, 2026
e886936
Merge branch 'feat/provider-error-handling' into copilot/sub-pr-217
mfeltscher Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/cache-tags/provider/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,14 @@ export abstract class AbstractErrorHandlingCacheTagsProvider implements CacheTag
return await fn();
} catch (error) {
const provider = this.providerName;
this.onError?.(error, { provider, method, args });

// Call onError callback if provided, but guard against exceptions
// to prevent masking the original provider error
try {
this.onError?.(error, { provider, method, args });
} catch (handlerError) {
console.error(`Error handler itself failed in ${provider}.${method}.`, { handlerError });
}

if (this.throwOnError) {
throw error;
Expand Down