Add token pagination for list sights endpoint#150
Merged
denislavstanchev merged 8 commits intomainlinefrom Dec 16, 2025
Merged
Conversation
Reviewing your PR now. Feedback on the way! |
ggoranov-smar
requested changes
Dec 16, 2025
Contributor
ggoranov-smar
left a comment
ggoranov-smar
left a comment
There was a problem hiding this comment.
With this many changes to lib/sights/index.ts you should make sure that all requests/responses actually work.
I'd suggest doing a couple manual tests since creating mappings for dashboards would be a serious endeavor.
ggoranov-smar
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.