perf: Allow event to release sleep#97
Open
ChristofferCOASD wants to merge 1 commit intosnakemake:mainfrom
Open
perf: Allow event to release sleep#97ChristofferCOASD wants to merge 1 commit intosnakemake:mainfrom
ChristofferCOASD wants to merge 1 commit intosnakemake:mainfrom
Conversation
Contributor
📝 Walkthrough📝 WalkthroughPre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
@johanneskoester would i be possible to have this merged? It would provide some upsides for short running rules as described in |
Author
|
@jjjermiah would you be able to review this one? I see you have be involved with other PRs 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow an event to release the sleep. This is useful if a Snake file also has small miscellaneous jobs but still is configured to use a remote executor.
This would fix
snakemake/snakemake-executor-plugin-slurm#252
@johanneskoester would this be somthing that could be merged into master?
Summary by CodeRabbit