This repository was archived by the owner on Apr 23, 2020. It is now read-only.
Log tab XSS fix #369
Open
Log tab XSS fix #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A creator of a UITab may designate the tab to serve HTML content. This is reflected in the "html" variable of the corresponding UITabSpec. The previous commit for issue soabase#331 would have rendered all custom tab content as plain text, which may have ruined someone's day if they were hoping that their custom tab's content would render as HTML. This change renders custom tab content as text or HTML depending on the "html" variable. For the Log tab, the content is plain text.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old: custom tabs' content was 100% considered to be HTML, thanks to jQuery's load method.
The "Log" tab was one such custom tab.
New: custom tabs' content is now either text or HTML, depending on the value of the
UITabSpecassociated with the custom tab.It should be noted that, with this fix, HTML-intended custom tabs are still potentially vulnerable to cross-site scripting, and must appropriately escape or encode any data they want to output to an HTML context.