Closed
Conversation
Solved error in decoding special chars in comments of device.
add iso decode to try
jgoclawski
requested changes
May 29, 2021
Member
jgoclawski
left a comment
jgoclawski
left a comment
There was a problem hiding this comment.
Hi, thanks for the contribution. Could you please add a few tests to document handled cases?
And why is "iso8859-1" handled separately? Is it not properly handled by cchardet?
Author
|
yes off course, it's because in some cases when the chardet try to decode some acentuation and it got a error off a unknow decode. |
add tests to check decode errors
removed iso decode and check if bytes aren't blank to detect type of decode.
Author
|
i've added two tests one to check byte decode and another to check if bytes are blank, i've removed the iso decode too |
|
@wagneracacio |
Member
|
Fixed in #104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved error in decoding special chars in comments of device.