Feature phpcs xml and pathfix#30
Closed
benallfree wants to merge 3 commits intosoderlind:masterfrom
benallfree:feature-phpcs-xml-and-pathfix
Closed
Feature phpcs xml and pathfix#30benallfree wants to merge 3 commits intosoderlind:masterfrom benallfree:feature-phpcs-xml-and-pathfix
benallfree wants to merge 3 commits intosoderlind:masterfrom
benallfree:feature-phpcs-xml-and-pathfix
Conversation
Open
jonnyijapan
approved these changes
Apr 3, 2019
|
What's the reason for the temporary file? If this VSCode extension just operated on the PHP file in-place, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 things:
Integrates PR Search for phpcs.xml file in workspace root folder #29
Fixes a bug where
phpcbf.standardwas not resolving paths correctlyFixes Does Nothing! #21. Exec path needs to be set to the project root so it can correctly search for
installed_pathsviaphpcs --config-set installed_paths <path/to/custom/coding/standard>