Skip to content

Feature phpcs xml and pathfix#30

Closed
benallfree wants to merge 3 commits intosoderlind:masterfrom
benallfree:feature-phpcs-xml-and-pathfix
Closed

Feature phpcs xml and pathfix#30
benallfree wants to merge 3 commits intosoderlind:masterfrom
benallfree:feature-phpcs-xml-and-pathfix

Conversation

@benallfree
Copy link

This PR fixes 3 things:

  1. Integrates PR Search for phpcs.xml file in workspace root folder #29

  2. Fixes a bug where phpcbf.standard was not resolving paths correctly

  3. Fixes Does Nothing! #21. Exec path needs to be set to the project root so it can correctly search for installed_paths via phpcs --config-set installed_paths <path/to/custom/coding/standard>

@benallfree benallfree mentioned this pull request Apr 2, 2019
@dossy
Copy link

dossy commented Feb 25, 2020

What's the reason for the temporary file? If this VSCode extension just operated on the PHP file in-place, the phpcbf script automatically looks for and navigates up parent directories looking for a series of phpcs.xml-like filenames and uses the first one it finds ... the whole temp file thing breaks this very elegant mechanism.

@benallfree benallfree closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does Nothing!

3 participants