Added ability to pass the gradient function to Adadelta#24
Open
Added ability to pass the gradient function to Adadelta#24
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=========================================
- Coverage 96.68% 96.59% -0.1%
=========================================
Files 26 26
Lines 2084 2087 +3
Branches 332 333 +1
=========================================
+ Hits 2015 2016 +1
- Misses 55 56 +1
- Partials 14 15 +1
Continue to review full report at Codecov.
|
Member
|
Why is the coverage going down here? Do we have the ability to put a test in place, which tests the stochastic gradient function? |
Member
|
We need to put in the test case here! Then we can merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding ability to pass along the gradient function to use for Adadelta, necessary for doing stochastic gradients with GPy models.