Open
Conversation
… in model and test files
Collaborator
Author
|
Hi @mzwiessele , It seems like replacing the Do you have any idea on how we can fix this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the release of
numpy>=2, themy_array.dataaccess got removed.This is used deep inside
paramzwhich makes it incompatible with modernnumpyversions.Since
numpyis a core dependency of pretty much anything in scientific computing, this needs to be fixed.The way the
.dataaccessor was used inparamzis to update the memory location of existing arrays, without re-creating them and without creating temporary data copies.As off now, it seems like this is something that is not possible anymore in
numpy>=2, at least, I could not figure out how - at least for now.What does this PR do?
It may make sense to split this up into multiple PRs later. Sorry for the mess atm.
I have added a
_set_mem_addrfunction inparamz.util.pythat serves as a baseline for the problematic update that is still not fixed.The current variants works with
numpy<2but fails otherwise.If anyone has got some idea on how to better debug or even fix this, feel free to join :)
Also, this is not based on develop but master. The reason for this is that the latest merge into development seems to have broken something else. We'll fix that later.