Added basic error checking to fix module crash#5
Open
SimplyMinimal wants to merge 1 commit intosoftware-2:masterfrom
Open
Added basic error checking to fix module crash#5SimplyMinimal wants to merge 1 commit intosoftware-2:masterfrom
SimplyMinimal wants to merge 1 commit intosoftware-2:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when the module crashes, Home Assistant would not automatically reload aurora.py. When that happens the Nanoleaf can no longer be controlled through Home Assistant until HA is restarted.
I have added basic error checking in the places I notice it would crash to prevent this from happening. I've tested this for a few weeks and had no problems.
The root cause is something passes a value of None to the affected functions in this change but I didn't dig deep enough to figure out what was causing this in the first place.