Merged
Conversation
poneciak57
requested changes
Feb 2, 2026
packages/react-native-audio-api/common/cpp/audioapi/utils/AudioArray.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/AudioArray.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/AudioBus.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/AudioBus.h
Outdated
Show resolved
Hide resolved
michalsek
reviewed
Feb 3, 2026
packages/react-native-audio-api/common/cpp/audioapi/utils/AudioArray.cpp
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a major internal refactoring of the audio utilities layer, consolidating the dual-class AudioBus/AudioBuffer system into a single AudioBuffer class and modernizing the AudioArray implementation. The changes improve memory safety through smart pointers, add modern C++ features like spans and move semantics, and convert several utility classes to header-only implementations for better optimization.
Changes:
- Renamed
AudioBustoAudioBufferthroughout the entire codebase - Enhanced
AudioArraywith move semantics, span support, iterator support, and new utility methods - Introduced
AudioArrayBufferas a JSI-compatible buffer type - Converted Windows, AudioUtils, and ParamChangeEvent to header-only implementations
- Modernized memory management from raw pointers to smart pointers
Reviewed changes
Copilot reviewed 125 out of 125 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| AudioBuffer.h/cpp | New consolidated audio buffer implementation with improved API |
| AudioArray.h/cpp | Enhanced with modern C++, span support, and additional utility methods |
| AudioArrayBuffer.hpp | New JSI-compatible buffer adapter |
| All *Node files | Updated to use AudioBuffer and reference-based APIs |
| Test files | Updated to use new span-based APIs |
| Windows.hpp | Converted to header-only with span support |
| AudioUtils.hpp | Converted to header-only with inline implementations |
| ParamChangeEvent.hpp | Converted to header-only with inline constructor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ca07daf to
a87f2f7
Compare
poneciak57
requested changes
Feb 5, 2026
packages/react-native-audio-api/common/cpp/audioapi/core/effects/GainNode.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/PeriodicWave.h
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/WorkletProcessingNode.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/sources/ConstantSourceNode.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/AudioBuffer.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/libs/ffmpeg/FFmpegDecoding.cpp
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/CircularAudioArray.cpp
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/CircularAudioArray.cpp
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/CircularAudioArray.cpp
Show resolved
Hide resolved
michalsek
requested changes
Feb 5, 2026
...s/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/CircularAudioArray.h
Show resolved
Hide resolved
packages/custom-node-generator/templates/basic/shared/MyProcessorNode.cpp
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/ConvolverNode.cpp
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/inputs/AudioRecorder.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/sources/StreamerNode.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/OfflineAudioContext.cpp
Outdated
Show resolved
Hide resolved
michalsek
approved these changes
Feb 5, 2026
mdydek
requested changes
Feb 6, 2026
packages/react-native-audio-api/common/cpp/audioapi/utils/AudioBuffer.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/AudioBuffer.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/AudioBuffer.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/AudioBuffer.cpp
Show resolved
Hide resolved
packages/react-native-audio-api/ios/audioapi/ios/core/utils/AudioDecoder.mm
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/dsp/Convolver.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/utils/AudioStretcher.h
Outdated
Show resolved
Hide resolved
added 2 commits
February 6, 2026 18:04
mdydek
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
CustomAudioProcessormethods in templateIntroduced changes
AudioArrayandAudioBus.AudioBusandAudioBufferinto one classMain goal of above changes is to introduce some kind of unification in operating on audio data. From today we should only use
AudioArrayas an abstraction over pcm channel data andAudioBufferas vector of channels.Rules:
Checklist