WIP: Scheduled tests by franciszekjob · Pull Request #1690 · software-mansion/starknet.py

franciszekjob · 2026-01-08T09:10:42Z

Stack

Closes #1681

Introduced changes

Add workflow which dispatches compatibility tests for relevant SDK versions targeting currently supported RPC versions
Add compatibility tests

This PR contains breaking changes

This reverts commit 334e28f.

…e-mansion/starknet.py into scheduled-tests

…nsion/starknet.py into scheduled-tests

…e-mansion/starknet.py into scheduled-tests

Copilot

Pull request overview

This PR introduces scheduled tests functionality to run network tests against multiple RPC versions, addressing issue #1681. The implementation includes a dispatcher workflow that triggers tests on different SDK repositories with various RPC version configurations.

Changes:

Added scheduled tests workflow for running network tests on testnet with configurable RPC versions
Added dispatcher workflow to orchestrate test runs across multiple RPC versions and SDK repositories
Created a composite action for dispatching workflow runs to target repositories

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
`.github/workflows/scheduled-tests.yml`	Defines the test execution workflow with setup and network testing jobs
`.github/workflows/scheduled-tests-dispatcher.yml`	Orchestrates scheduled test runs across multiple RPC versions and repositories
`.github/actions/dispatch-scheduled-tests/action.yml`	Composite action for dispatching workflow runs via GitHub API

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-12T12:51:06Z

.github/workflows/compatibility-tests.yml

+                RPC_VERION="${{ inputs.rpc_version }}"
+                URL="${URL%/}" # Remove trailing slash if any
+                URL="${URL%/*}" # Get base URL without version
+                RPC_URL="${URL}/${RPC_VERION}"


Typo in variable name: "RPC_VERION" should be "RPC_VERSION".

Suggested change

RPC_VERION="${{ inputs.rpc_version }}"

URL="${URL%/}" # Remove trailing slash if any

URL="${URL%/*}" # Get base URL without version

RPC_URL="${URL}/${RPC_VERION}"

RPC_VERSION="${{ inputs.rpc_version }}"

URL="${URL%/}" # Remove trailing slash if any

URL="${URL%/*}" # Get base URL without version

RPC_URL="${URL}/${RPC_VERSION}"

Copilot · 2026-01-12T12:51:07Z

.github/workflows/compatibility-tests.yml

+                RPC_VERION="${{ inputs.rpc_version }}"
+                URL="${URL%/}" # Remove trailing slash if any
+                URL="${URL%/*}" # Get base URL without version
+                RPC_URL="${URL}/${RPC_VERION}"


The typo in variable name "RPC_VERION" will cause the URL construction to use an empty value. This variable is referenced on line 103 but defined incorrectly on line 100, which will result in an incorrect RPC URL being set.

Suggested change

RPC_VERION="${{ inputs.rpc_version }}"

URL="${URL%/}" # Remove trailing slash if any

URL="${URL%/*}" # Get base URL without version

RPC_URL="${URL}/${RPC_VERION}"

RPC_VERSION="${{ inputs.rpc_version }}"

URL="${URL%/}" # Remove trailing slash if any

URL="${URL%/*}" # Get base URL without version

RPC_URL="${URL}/${RPC_VERSION}"

Copilot · 2026-01-12T12:51:07Z

.github/workflows/scheduled-tests-dispatcher.yml

+name: Run scheduled tests with multiple RPC versions
+
+on:
+  pull_request:


The workflow is triggered on pull_request events (line 4), which means it will dispatch scheduled tests to other repositories for every pull request. This could cause excessive workflow runs and consume resources unnecessarily. Consider restricting this to only run on schedule and workflow_dispatch, or add a condition to check if the PR modifies specific files.

Suggested change

pull_request:

Copilot · 2026-01-12T12:51:08Z

.github/actions/dispatch-compatibility-tests/action.yml

+        curl -f -sS -X POST \
+            -H "Authorization: Bearer ${GH_TOKEN}" \
+            -H "Accept: application/vnd.github+json" \
+            "https://api.github.com/repos/${REPO}/actions/workflows/${WORKFLOW_FILE}/dispatches" \
+            -d "{\"ref\":\"${REF}\",\"inputs\":{\"rpc_version\":\"${RPC_VERSION}\"}}"
+
+        echo "Dispatched ${REPO}@${REF} workflow ${WORKFLOW_FILE} with rpc_version=${RPC_VERSION}"
+


The curl command lacks error handling context. When the curl command fails (due to -f flag), the error message won't indicate which repository or workflow failed. Consider adding an echo statement before the curl command to log which workflow is being dispatched, or add error handling that provides more context about the failure.

Suggested change

curl -f -sS -X POST \

-H "Authorization: Bearer ${GH_TOKEN}" \

-H "Accept: application/vnd.github+json" \

"https://api.github.com/repos/${REPO}/actions/workflows/${WORKFLOW_FILE}/dispatches" \

-d "{\"ref\":\"${REF}\",\"inputs\":{\"rpc_version\":\"${RPC_VERSION}\"}}"

echo "Dispatched ${REPO}@${REF} workflow ${WORKFLOW_FILE} with rpc_version=${RPC_VERSION}"

echo "Dispatching workflow '${WORKFLOW_FILE}' to repository '${REPO}' at ref '${REF}' with rpc_version='${RPC_VERSION}'"

if ! curl -f -sS -X POST \

-H "Authorization: Bearer ${GH_TOKEN}" \

-H "Accept: application/vnd.github+json" \

"https://api.github.com/repos/${REPO}/actions/workflows/${WORKFLOW_FILE}/dispatches" \

-d "{\"ref\":\"${REF}\",\"inputs\":{\"rpc_version\":\"${RPC_VERSION}\"}}"; then

echo "Error: Failed to dispatch workflow '${WORKFLOW_FILE}' to repository '${REPO}' at ref '${REF}' with rpc_version='${RPC_VERSION}'" >&2

exit 1

fi

echo "Successfully dispatched ${REPO}@${REF} workflow ${WORKFLOW_FILE} with rpc_version=${RPC_VERSION}"

Copilot · 2026-01-12T12:51:08Z

.github/actions/dispatch-compatibility-tests/action.yml

+        curl -f -sS -X POST \
+            -H "Authorization: Bearer ${GH_TOKEN}" \
+            -H "Accept: application/vnd.github+json" \
+            "https://api.github.com/repos/${REPO}/actions/workflows/${WORKFLOW_FILE}/dispatches" \
+            -d "{\"ref\":\"${REF}\",\"inputs\":{\"rpc_version\":\"${RPC_VERSION}\"}}"
+
+        echo "Dispatched ${REPO}@${REF} workflow ${WORKFLOW_FILE} with rpc_version=${RPC_VERSION}"
+


The curl command could expose the GitHub token in logs if debugging is enabled. While the token is passed through an environment variable which is generally safe, consider using the GitHub CLI (gh) instead which provides built-in token handling and better security practices. For example: gh workflow run "$WORKFLOW_FILE" --repo "$REPO" --ref "$REF" --field rpc_version="$RPC_VERSION".

Suggested change

curl -f -sS -X POST \

-H "Authorization: Bearer ${GH_TOKEN}" \

-H "Accept: application/vnd.github+json" \

"https://api.github.com/repos/${REPO}/actions/workflows/${WORKFLOW_FILE}/dispatches" \

-d "{\"ref\":\"${REF}\",\"inputs\":{\"rpc_version\":\"${RPC_VERSION}\"}}"

echo "Dispatched ${REPO}@${REF} workflow ${WORKFLOW_FILE} with rpc_version=${RPC_VERSION}"

gh workflow run "${WORKFLOW_FILE}" \

--repo "${REPO}" \

--ref "${REF}" \

--field rpc_version="${RPC_VERSION}"

echo "Dispatched ${REPO}@${REF} workflow ${WORKFLOW_FILE} with rpc_version=${RPC_VERSION}"

franciszekjob added 16 commits January 8, 2026 10:10

WIP: Add workflows for scheduled tests and dispatcher

4306cb3

Fix matrix structure

fb320a4

Fix formatting

428c959

Fix curl command

5759c13

Add job name

7035024

Fix url

0bcd928

Add todo

89690f6

WIP

84d4ad3

Add client_payload

29f8131

Fix token name

3a9e693

WIP

334e28f

Revert "WIP"

8a8f167

This reverts commit 334e28f.

Restore using curl

fe54f7d

Fix reading rpc version from input

f64475d

Update job name

bc29d1f

Merge branch 'move-devnet-client-tests' of https://github.com/softwar…

072d66c

…e-mansion/starknet.py into scheduled-tests

franciszekjob changed the title ~~WIP: Add workflows for scheduled tests and dispatcher~~ WIP: Scheduled tests Jan 8, 2026

franciszekjob changed the base branch from extend-network-tests to move-devnet-client-tests January 8, 2026 11:25

franciszekjob added 12 commits January 8, 2026 12:29

Merge branch 'move-devnet-client-tests' of https://github.com/softwar…

c30f590

…e-mansion/starknet.py into scheduled-tests

Merge branch 'move-devnet-client-tests' of https://github.com/softwar…

aca2cf7

…e-mansion/starknet.py into scheduled-tests

WIP

a5933eb

Merge branch 'extend-network-tests' of https://github.com/software-ma…

70963f0

…nsion/starknet.py into scheduled-tests

Replace versions

4a91277

Merge branch 'move-devnet-client-tests' of https://github.com/softwar…

b309da4

…e-mansion/starknet.py into scheduled-tests

Pull upstream

509d356

Merge branch 'move-devnet-client-tests' of https://github.com/softwar…

7a0a815

…e-mansion/starknet.py into scheduled-tests

Add checkout step

f2a0ff1

Update ref

a418cb6

Update steps with contracts cache and compilation

9668b89

Merge branch 'move-devnet-client-tests' of https://github.com/softwar…

5d3680d

…e-mansion/starknet.py into scheduled-tests

franciszekjob added 9 commits January 12, 2026 03:18

Add todos

8f0d0f1

Merge branch 'move-devnet-client-tests' of https://github.com/softwar…

766dc55

…e-mansion/starknet.py into scheduled-tests

Fix versions matrix

fd3806c

Fix matrix

69f7da3

Fix indentation

a2b2c7b

Conditionally run dispatching steps for jvm and swift

34658e7

Conditionally run dispatching step for py too

a3def09

Remove matrix usage for python version

1012c6a

Ignore cache for salted contracts

e74b341

This was referenced Jan 12, 2026

Remove duplicated contracts compilation #1694

Merged

Refactor contracts utils #1695

Merged

Extend network tests #1689

Open

Move devnet client tests #1692

Open

franciszekjob requested a review from Copilot January 12, 2026 12:48

Copilot started reviewing on behalf of franciszekjob January 12, 2026 12:49 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

Rename "scheduled" -> "compatibility"

6fd91e5

franciszekjob closed this Jan 12, 2026

franciszekjob deleted the scheduled-tests branch January 12, 2026 12:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Scheduled tests#1690

WIP: Scheduled tests#1690
franciszekjob wants to merge 38 commits intomove-devnet-client-testsfrom
scheduled-tests

franciszekjob commented Jan 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

franciszekjob commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Introduced changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

franciszekjob commented Jan 8, 2026 •

edited

Loading