Skip to content

Compatibility tests#1697

Open
franciszekjob wants to merge 63 commits intomove-devnet-client-testsfrom
compatibility-tests
Open

Compatibility tests#1697
franciszekjob wants to merge 63 commits intomove-devnet-client-testsfrom
compatibility-tests

Conversation

@franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Jan 12, 2026

Stack

Closes #1681

Introduced changes

  • Add workflow which dispatches compatibility tests for relevant SDK versions targeting currently supported RPC versions range
  • Add compatibility tests

  • This PR contains breaking changes

This reverts commit 334e28f.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces compatibility testing infrastructure to test SDK versions against different RPC versions. The changes add GitHub Actions workflows to dispatch compatibility tests across multiple SDK repositories (starknet.py, starknet-jvm, starknet.swift) targeting currently supported RPC versions (v0_8, v0_9, v0_10).

Changes:

  • Added a dispatcher workflow that triggers compatibility tests for multiple RPC versions (v0_8, v0_9, v0_10)
  • Added a compatibility tests workflow that runs network tests against testnet with configurable RPC versions
  • Added a reusable GitHub Action to dispatch compatibility test workflows to target repositories

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
.github/workflows/compatibility-tests.yml Defines the compatibility test workflow with setup and network testing jobs
.github/workflows/compatibility-tests-dispatcher.yml Orchestrates dispatching compatibility tests across multiple SDK repositories
.github/actions/dispatch-compatibility-tests/action.yml Reusable action for dispatching compatibility test workflows via GitHub API

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@franciszekjob franciszekjob marked this pull request as ready for review January 13, 2026 18:15
@franciszekjob
Copy link
Collaborator Author

franciszekjob commented Jan 13, 2026

note: compatibility-tests.yml is failing here, as it's automatically run with an empty rpc_version input. The actual run triggered by the dispatcher workflow (i.e. with the input) can be found e.g. here: https://github.com/software-mansion/starknet.py/actions/runs/20966108374

@franciszekjob
Copy link
Collaborator Author

note: Once we approve compatibility-tests.yml, we need to backport to relevant versions targeting RPC 0.8 and 0.9, perhaps on additional branches.

@franciszekjob franciszekjob requested a review from a team January 13, 2026 18:29
Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rerun workflow tests to see if they pass?

Comment on lines +18 to +20
gh_token:
description: 'GitHub token for API authentication'
required: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use one token for all repos, can we simply inherit secrets and not pass it as an argument here?

Comment on lines 34 to 38
curl -f -sS -X POST \
-H "Authorization: Bearer ${GH_TOKEN}" \
-H "Accept: application/vnd.github+json" \
"https://api.github.com/repos/${REPO}/actions/workflows/${WORKFLOW_FILE}/dispatches" \
-d "{\"ref\":\"${REF}\",\"inputs\":{\"rpc_version\":\"${RPC_VERSION}\"}}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use gh cli instead?


on:
workflow_dispatch:
pull_request:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be removed later?

@franciszekjob franciszekjob mentioned this pull request Feb 3, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants