Compatibility tests#1697
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces compatibility testing infrastructure to test SDK versions against different RPC versions. The changes add GitHub Actions workflows to dispatch compatibility tests across multiple SDK repositories (starknet.py, starknet-jvm, starknet.swift) targeting currently supported RPC versions (v0_8, v0_9, v0_10).
Changes:
- Added a dispatcher workflow that triggers compatibility tests for multiple RPC versions (v0_8, v0_9, v0_10)
- Added a compatibility tests workflow that runs network tests against testnet with configurable RPC versions
- Added a reusable GitHub Action to dispatch compatibility test workflows to target repositories
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
.github/workflows/compatibility-tests.yml |
Defines the compatibility test workflow with setup and network testing jobs |
.github/workflows/compatibility-tests-dispatcher.yml |
Orchestrates dispatching compatibility tests across multiple SDK repositories |
.github/actions/dispatch-compatibility-tests/action.yml |
Reusable action for dispatching compatibility test workflows via GitHub API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This reverts commit 40ab655. # Conflicts: # .github/actions/dispatch-compatibility-tests/action.yml
…e-mansion/starknet.py into compatibility-tests
…nsion/starknet.py into compatibility-tests
…e-mansion/starknet.py into compatibility-tests
…e-mansion/starknet.py into compatibility-tests
|
note: |
|
note: Once we approve |
ddoktorski
left a comment
There was a problem hiding this comment.
Could you rerun workflow tests to see if they pass?
| gh_token: | ||
| description: 'GitHub token for API authentication' | ||
| required: true |
There was a problem hiding this comment.
If we use one token for all repos, can we simply inherit secrets and not pass it as an argument here?
| curl -f -sS -X POST \ | ||
| -H "Authorization: Bearer ${GH_TOKEN}" \ | ||
| -H "Accept: application/vnd.github+json" \ | ||
| "https://api.github.com/repos/${REPO}/actions/workflows/${WORKFLOW_FILE}/dispatches" \ | ||
| -d "{\"ref\":\"${REF}\",\"inputs\":{\"rpc_version\":\"${RPC_VERSION}\"}}" |
There was a problem hiding this comment.
Would it be possible to use gh cli instead?
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: |
There was a problem hiding this comment.
Should it be removed later?
…e-mansion/starknet.py into compatibility-tests
Stack
scarbto2.15.0#1701Closes #1681
Introduced changes