Skip to content

Conversation

@rogaldh
Copy link
Contributor

@rogaldh rogaldh commented Dec 30, 2025

Description

PR performs changes to enable "Interactive Idl" feature

IMPORTANT: This PR is for testing purposes with a Preview Build. Should be amended before the release.

Type of change

  • Bug fix
  • New feature
  • Protocol integration
  • Documentation update
  • Other (please describe):

Screenshots

Testing

Related Issues

Checklist

  • My code follows the project's style guidelines
  • I have added tests that prove my fix/feature works
  • All tests pass locally and in CI
  • I have updated documentation as needed
  • I have run build:info script to update build information
  • CI/CD checks pass
  • I have included screenshots for protocol screens (if applicable)
  • For security-related features, I have included links to related information

Additional Notes


Important

Change sampleRate to 1 in createSentryConfig to enable full issue tracking in Sentry.

  • Behavior:
    • Change sampleRate from 0.1 to 1 in createSentryConfig in config.mjs, enabling full issue tracking instead of 10%.

This description was created by Ellipsis for 6f24e9c. You can customize this summary. It will automatically update as commits are pushed.

@vercel
Copy link

vercel bot commented Dec 30, 2025

@rogaldh is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
explorer Ready Ready Preview, Comment Dec 30, 2025 6:41pm

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 6f24e9c in 1 minute and 26 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. sentry/config.mjs:12
  • Draft comment:
    Raising sampleRate to 1 will capture 100% of events. Confirm if this is intended for production or if it should be configurable to avoid performance/cost impacts.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment violates the rule "Do NOT ask the PR author to confirm their intention, to explain, to double-check things, to ensure the behavior is intended". The comment explicitly says "Confirm if this is intended". Additionally, the comment seems to misunderstand how Sentry works - the sampleRate of 1 means 100% of ERROR events are captured, but the tracesSampler controls trace sampling separately (which is set to 1/100000000). The author clearly knows what they're doing given the sophisticated tracesSampler implementation. This comment is asking for confirmation rather than pointing out a definite issue. I might be wrong about how sampleRate and tracesSampler interact in Sentry. Perhaps sampleRate does have a performance/cost impact even with a low tracesSampler rate. However, the comment is still asking for confirmation rather than stating a definite problem. Even if there could be a performance concern, the comment explicitly asks to "Confirm if this is intended" which violates the rules. The comment should either state a definite problem or not be made at all. The author has clearly thought about sampling given the detailed tracesSampler implementation. This comment should be deleted because it asks the author to confirm their intention, which is explicitly against the rules. The comment is not pointing out a definite issue, but rather asking for verification.
2. sentry/config.mjs:11
  • Draft comment:
    The PR description references resolving a transaction history issue for deleted accounts, but this diff only updates Sentry config. Verify that the intended changes are included.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify that the intended changes are included, which violates the rule against asking the author to confirm their intention or ensure behavior is intended. The comment does not provide a specific code suggestion or request for tests, and it focuses on the PR description, which is also against the rules.

Workflow ID: wflow_BbzVEqGZbMp54Vh6

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@rogaldh rogaldh changed the title chore: Enable Interactive Idls feature feat: Enable Interactive Idls feature Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants