[swss.sh]: Cleanup hft table in state db #25003
Conversation
Signed-off-by: Ze Gan <ganze718@gmail.com>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This pull request adds cleanup for the high frequency telemetry (HFT) session table in STATE_DB during config reload operations. The change ensures that the HIGH_FREQUENCY_TELEMETRY_SESSION_TABLE* entries are properly cleaned up when the SWSS service starts, addressing an issue where these entries persisted after config reload.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
files/scripts/swss.sh
Outdated
| $SONIC_DB_CLI GB_COUNTERS_DB FLUSHDB | ||
| $SONIC_DB_CLI RESTAPI_DB FLUSHDB | ||
| clean_up_tables STATE_DB "'PORT_TABLE*', 'MGMT_PORT_TABLE*', 'VLAN_TABLE*', 'VLAN_MEMBER_TABLE*', 'LAG_TABLE*', 'LAG_MEMBER_TABLE*', 'INTERFACE_TABLE*', 'MIRROR_SESSION*', 'VRF_TABLE*', 'FDB_TABLE*', 'FG_ROUTE_TABLE*', 'BUFFER_POOL*', 'BUFFER_PROFILE*', 'MUX_CABLE_TABLE*', 'ADVERTISE_NETWORK_TABLE*', 'VXLAN_TUNNEL_TABLE*', 'VNET_ROUTE*', 'MACSEC_PORT_TABLE*', 'MACSEC_INGRESS_SA_TABLE*', 'MACSEC_EGRESS_SA_TABLE*', 'MACSEC_INGRESS_SC_TABLE*', 'MACSEC_EGRESS_SC_TABLE*', 'VRF_OBJECT_TABLE*', 'VNET_MONITOR_TABLE*', 'BFD_SESSION_TABLE*', 'SYSTEM_NEIGH_TABLE*', 'FABRIC_PORT_TABLE*', 'TUNNEL_DECAP_TABLE*', 'TUNNEL_DECAP_TERM_TABLE*'" | ||
| clean_up_tables STATE_DB "'PORT_TABLE*', 'MGMT_PORT_TABLE*', 'VLAN_TABLE*', 'VLAN_MEMBER_TABLE*', 'LAG_TABLE*', 'LAG_MEMBER_TABLE*', 'INTERFACE_TABLE*', 'MIRROR_SESSION*', 'VRF_TABLE*', 'FDB_TABLE*', 'FG_ROUTE_TABLE*', 'BUFFER_POOL*', 'BUFFER_PROFILE*', 'MUX_CABLE_TABLE*', 'ADVERTISE_NETWORK_TABLE*', 'VXLAN_TUNNEL_TABLE*', 'VNET_ROUTE*', 'MACSEC_PORT_TABLE*', 'MACSEC_INGRESS_SA_TABLE*', 'MACSEC_EGRESS_SA_TABLE*', 'MACSEC_INGRESS_SC_TABLE*', 'MACSEC_EGRESS_SC_TABLE*', 'VRF_OBJECT_TABLE*', 'VNET_MONITOR_TABLE*', 'BFD_SESSION_TABLE*', 'SYSTEM_NEIGH_TABLE*', 'FABRIC_PORT_TABLE*', 'TUNNEL_DECAP_TABLE*', 'TUNNEL_DECAP_TERM_TABLE*, 'HIGH_FREQUENCY_TELEMETRY_SESSION_TABLE*' " |
There was a problem hiding this comment.
There is a syntax error in the table list. The closing single quote is missing after 'TUNNEL_DECAP_TERM_TABLE*', which will cause a shell parsing error. The string should be 'TUNNEL_DECAP_TERM_TABLE*' instead of 'TUNNEL_DECAP_TERM_TABLE*,
There was a problem hiding this comment.
@Pterosaur copiliot comment looks valid, could you update the file.
There was a problem hiding this comment.
I don't think so. I have that single quote already.
There was a problem hiding this comment.
@Pterosaur This is to TUNNEL_DECAP_TERM_TABLE and not the new HFT table
There was a problem hiding this comment.
Oh, my bad... I didn't notice that...Fixed it.
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ze Gan <ganze718@gmail.com>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 participants
Why I did it
The hft table in state db wasn't cleanup after config reload
Work item tracking
How I did it
Add hft table name in swss.sh
How to verify it
Check it locally
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)