feat(cli): add ability to create multiple services#2118
Open
Surbhi-sharma1 wants to merge 2 commits intomasterfrom
Open
feat(cli): add ability to create multiple services#2118Surbhi-sharma1 wants to merge 2 commits intomasterfrom
Surbhi-sharma1 wants to merge 2 commits intomasterfrom
Conversation
Surbhi-sharma1
force-pushed
the
GH-2112
branch
4 times, most recently
from
4c29899 to
88fb2f1
Compare
yeshamavani
reviewed
Jul 1, 2024
Comment on lines
+51
to
+68
| const baseService = (inputs.flags as AnyObject).baseService; | ||
| if ( | ||
| type === 'microservice' && | ||
| Array.isArray(baseService) && | ||
| baseService.length > 0 | ||
| ) { | ||
| for (const service of baseService) { | ||
| const envS = this.getEnv(process.cwd(), 'microservice'); | ||
| const currentInputs = {...inputs}; | ||
| currentInputs.flags = {...inputs.flags, baseService: service}; | ||
|
|
||
| await this.runWithEnv(envS, type, [service], { | ||
| ...currentInputs.args, | ||
| ...currentInputs.flags, | ||
| }); | ||
| } | ||
| } else { | ||
| this.env.register( |
Contributor
There was a problem hiding this comment.
if by default we are passing the name of the service then why are we taking it from the user
same for other default parameters
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add ability to create multiple services
GH-2112
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #2112
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: