This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/enterpriseportal: implement SubscriptionLicenseChecksService #64400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
f07d4ff to
d5f0aa9
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
from
94fa17d to
6ff0aa7
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
d5f0aa9 to
da734d3
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
from
6ff0aa7 to
27ceb18
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
da734d3 to
9d3d1e1
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
from
27ceb18 to
9eea4f8
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
9d3d1e1 to
6c53ac5
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
2 times, most recently
from
3e3f661 to
9a29c0a
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
6c53ac5 to
d8b3432
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
from
9a29c0a to
a900ea0
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
d8b3432 to
8e0f2d9
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
from
a900ea0 to
0936f92
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
8e0f2d9 to
9f29a98
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
3 times, most recently
from
a068acd to
7efb957
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
from
7efb957 to
1af6201
Compare
eseliger
approved these changes
Aug 14, 2024
cmd/enterprise-portal/internal/database/subscriptions/licenses.go
Outdated
Show resolved
Hide resolved
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
9f29a98 to
f15b76f
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
from
2453a1b to
dce9782
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
f15b76f to
1ebd646
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
from
dce9782 to
44e077d
Compare
unknwon
approved these changes
Aug 15, 2024
Member
Author
There was a problem hiding this comment.
It's a new behaviour from the new gprc.NewClient:
The target name syntax is defined in https://github.com/grpc/grpc/blob/master/doc/naming.md. e.g. to use dns resolver, a "dns:///" prefix should be applied to the target.
cmd/enterprise-portal/internal/subscriptionlicensechecksservice/v1_store.go
Outdated
Show resolved
Hide resolved
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
1ebd646 to
01de0f8
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
from
0a28074 to
5ae3c79
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
01de0f8 to
ba89637
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
from
5ae3c79 to
46d63d8
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
ba89637 to
fab52ee
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
from
46d63d8 to
66d25d5
Compare
This was referenced Aug 15, 2024
Base automatically changed from
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
to
main
August 16, 2024 16:37
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
from
66d25d5 to
9e991a9
Compare
Contributor
|
✔️ Test ownership >= 70% again, thank you! |
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
from
9e991a9 to
db24d7e
Compare
bobheadxi
deleted the
08-09-feat_enterpriseportal_implement_subscriptionlicensechecksservice
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the RPC defined in https://github.com/sourcegraph/sourcegraph/pull/64396. Follow-up PRs will implement migrations for in-instance checks and for through-dotcom checks.
One major change is that we now bypass the check for subscriptions that are denoted as associated with
INTERNALinstances.Most of the diff is generated mocks.
Part of https://linear.app/sourcegraph/issue/CORE-227
Test plan
sg test enterprise-portal-e2e)