Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (1)
✏️ Tip: You can disable in-progress messages and the fortune message in your review settings. Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47fcdcb6a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| docker-build: | ||
| needs: build | ||
| if: github.event_name == 'push' |
There was a problem hiding this comment.
workflow_dispatch에서도 배포 단계가 실행되게 수정
on이 workflow_dispatch만 정의되어 있는데 주요 단계가 if: github.event_name == 'push'로 제한되어 있어 수동 실행 시 docker-build와 deploy가 항상 skip됩니다. 이 커밋의 목적이 프로덕션 CI/CD 추가라면 현재 조건에서는 이미지 푸시/배포가 절대 수행되지 않으므로, 이벤트 조건을 workflow_dispatch에 맞추거나 조건을 제거해 실제 배포 플로우가 동작하도록 해야 합니다.
Useful? React with 👍 / 👎.
|
|
||
| gcloud auth configure-docker asia-northeast3-docker.pkg.dev | ||
|
|
||
| ./deploy/prod/scripts/deploy.sh No newline at end of file |
There was a problem hiding this comment.
원격 실행 스크립트가 ./deploy/prod/scripts/deploy.sh를 호출하지만 현재 저장소에는 deploy/prod 디렉터리가 없고 deploy/dev만 있어(같은 workflow의 source: "deploy/*"도 prod를 전송하지 않음) 초기 환경에서는 chmod/스크립트 실행 단계가 실패합니다. prod 배포 파일을 저장소에 포함하거나 경로를 실제 전송되는 스크립트와 일치시키지 않으면 배포 파이프라인이 안정적으로 동작하지 않습니다.
Useful? React with 👍 / 👎.
Summary by CodeRabbit
릴리스 노트