Plan for removing the sovrin token. by esplinr · Pull Request #28 · sovrin-foundation/sovrin-sip

esplinr · 2021-01-24T05:04:54Z

No description provided.

Signed-off-by: Richard Esplin <richard.esplin@evernym.com>

askolesov

Look really great! I've suggested only minor improvements.

text/5005-token-removal/README.md

Signed-off-by: Richard Esplin <richard.esplin@evernym.com>

askolesov

Great work

Signed-off-by: Richard Esplin <richard.esplin@evernym.com>

esplinr · 2021-01-30T03:12:46Z

For reviewers: a convenient link to the PR for the Indy HIPEs that are linked in the SIP.

Three more recently discovered concerns. Signed-off-by: Richard Esplin <richard.esplin@evernym.com>

WadeBarnes · 2021-02-21T15:19:52Z

text/5005-token-removal/README.md

+* It has only been tested on Ubuntu 16.04, which will reach end-of-life in March 2021. The plugin could break while upgrading the Sovrin Networks to newer versions of Ubuntu.
+* It has only been tested on Python 3.5, which reached end-of-life in September 2020. The rest of Indy has been difficult to upgrade, so it is unlikely the token plugin will work.
+* It depends on the deprecated [Indy Crypto](https://github.com/hyperledger/indy-node), the predecessor to [Hyperledger Ursa](https://github.com/hyperledger/ursa). Indy Crypto has not received security updates or other improvements since October 2019. Because the rest of Indy uses Ursa, there is an additional risk of a dependency conflict.
+* It’s build process depends on the Sovrin deployment of Jenkins for CI / CD, which has not been maintained since early 2020. It is likely that the unit tests and system tests won’t run.


The Jenkins CI/CD process(es) runs the tests in containerized environments. If the test run on a developer's machine, they will run on the equivalent containerized environment during the build process.

I have no confidence that the tests will run on a developer's machine.

Current test failures are due in whole to dependency issues, details provided in the RC channels. Once those are addressed the tests will function in the containerized environments under Jenkins, or on a developers machine.

WadeBarnes · 2021-02-21T15:24:57Z

text/5005-token-removal/README.md

+* It has only been tested on Python 3.5, which reached end-of-life in September 2020. The rest of Indy has been difficult to upgrade, so it is unlikely the token plugin will work.
+* It depends on the deprecated [Indy Crypto](https://github.com/hyperledger/indy-node), the predecessor to [Hyperledger Ursa](https://github.com/hyperledger/ursa). Indy Crypto has not received security updates or other improvements since October 2019. Because the rest of Indy uses Ursa, there is an additional risk of a dependency conflict.
+* It’s build process depends on the Sovrin deployment of Jenkins for CI / CD, which has not been maintained since early 2020. It is likely that the unit tests and system tests won’t run.
+* It's testing process depends on [Indy SDK](https://github.com/hyperledger/indy-sdk/), which [has an uncertain future](https://github.com/hyperledger/indy-sdk/pull/2329) as development is focused on [Indy-VDR](https://github.com/hyperledger/indy-vdr/).


indy-sdk 1.16.0 was built 2021.02.21, moving forward, testing would need to migrate to the tools adopted by the community. This would be the same for indy-node.

Agreed. But we have volunteers to do that work for indy-node, and no one to do that work for the token.

text/5005-token-removal/README.md

WadeBarnes · 2021-02-21T15:50:50Z

Without the plugin (once the ledger has been frozen and the plugin removed) how can the ledger history be validated when there have been transactions processed by it?

esplinr · 2021-02-25T05:12:01Z

Wade asks:

Without the plugin (once the ledger has been frozen and the plugin removed) how can the ledger history be validated when there have been transactions processed by it?

The SIP explains:

Sovrin StagingNet is a stable ledger for demonstration and testing purposes. It is widely used even though no guarantees are made about the history of StagingNet. It is intended to be reset regularly but has never been reset in practice.

Sovrin BuilderNet is used to test new Indy releases for stability before the other Sovrin networks. It is useful for developers building solutions, but makes no guarantees about preserving history. BuilderNet was reset in June of 2020. It has an initialized token ledger and a history of only a few token transactions that include two SET_FEE transactions.

This policy is based on the Sovrin Steward Technical and Organizational Policies v2:

If at any time for any reason Personal Data is discovered on the Permissioned Test
Network:
a. The Sovrin Foundation MUST be notified immediately.
b. Within 48 hours of notification, the Sovrin Foundation MUST reset the Permissioned Test Network to erase the Personal Data.

But per @WadeBarnes 's suggestion, I made it more explicit here:

The history of transfers of value will be unrecoverably lost when the token ledger is dropped during the plugin removal. This is appropriate, because token transactions are only on the test networks (StagingNet and BuilderNet) where the history is not expected to be permanent (see Sovrin Steward Technical and Organizational Policies section "Permissioned Test Network Policies").

Edit from @WadeBarnes:
This covers the scenario where the ledger is dropped. What if the ledger is retained? i.e Ledger frozen, ledger (data) retained, plug-in removed (uninstalled).

Signed-off-by: Richard Esplin <richard.esplin@evernym.com>

esplinr · 2021-02-26T06:43:56Z

This covers the scenario where the ledger is dropped. What if the ledger is retained? i.e Ledger frozen, ledger (data) retained, plug-in removed (uninstalled).

I don't see how that is relevant to this SIP. Operation of the network is unaffected either way. We put in the extra effort to cleanly remove the data by dropping the ledger, because we want to leave the network in the best state for long term maintenance.

On MainNet, keeping an additional empty ledger around forever could cause us future complications simply due to the added complexity. Years in the future, it won't be obvious what the unused empty ledger is for.
On StagingNet and BuilderNet, I don't see why we would retain test data on a test network that by policy can be deleted at any time.

But it doesn't really matter either way.

Initial draft of a plan for removing the sovrin token.

811991d

Signed-off-by: Richard Esplin <richard.esplin@evernym.com>

askolesov reviewed Jan 25, 2021

View reviewed changes

Incorporating feedback from Alex K.

b8af942

Signed-off-by: Richard Esplin <richard.esplin@evernym.com>

esplinr force-pushed the sovrin-sip branch from 85b7cad to b8af942 Compare January 26, 2021 01:30

askolesov approved these changes Jan 26, 2021

View reviewed changes

esplinr changed the title ~~WIP Plan for removing the sovrin token.~~ Plan for removing the sovrin token. Jan 30, 2021

Updating link to split HIPE

33af573

Signed-off-by: Richard Esplin <richard.esplin@evernym.com>

esplinr mentioned this pull request Jan 30, 2021

HIPE for plugin helpers hyperledger-indy/indy-hipe#162

Merged

Adding more reasons to remove the token

921b357

Three more recently discovered concerns. Signed-off-by: Richard Esplin <richard.esplin@evernym.com>

WadeBarnes reviewed Feb 21, 2021

View reviewed changes

text/5005-token-removal/README.md Outdated Show resolved Hide resolved

WadeBarnes reviewed Feb 21, 2021

View reviewed changes

text/5005-token-removal/README.md Show resolved Hide resolved

WadeBarnes reviewed Feb 21, 2021

View reviewed changes

text/5005-token-removal/README.md Outdated Show resolved Hide resolved

WadeBarnes reviewed Feb 21, 2021

View reviewed changes

text/5005-token-removal/README.md Show resolved Hide resolved

esplinr force-pushed the sovrin-sip branch from 327d18a to 0b3d27c Compare February 25, 2021 05:49

Improvements based on suggestions by WadeBarnes.

d2e98d1

Signed-off-by: Richard Esplin <richard.esplin@evernym.com>

esplinr force-pushed the sovrin-sip branch from 0b3d27c to d2e98d1 Compare February 25, 2021 05:54

esplinr mentioned this pull request Feb 25, 2021

Update remove_ledger.py to protect against removing a ledger that has been used hyperledger-indy/indy-node#1659

Open

Conversation

esplinr commented Jan 24, 2021

Uh oh!

askolesov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

askolesov left a comment

Choose a reason for hiding this comment

Uh oh!

esplinr commented Jan 30, 2021

Uh oh!

WadeBarnes Feb 21, 2021

Choose a reason for hiding this comment

Uh oh!

esplinr Feb 25, 2021

Choose a reason for hiding this comment

Uh oh!

WadeBarnes Feb 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WadeBarnes Feb 21, 2021

Choose a reason for hiding this comment

Uh oh!

esplinr Feb 25, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WadeBarnes commented Feb 21, 2021

Uh oh!

esplinr commented Feb 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

esplinr commented Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WadeBarnes Feb 25, 2021 •

edited

Loading

esplinr commented Feb 25, 2021 •

edited

Loading

esplinr commented Feb 26, 2021 •

edited

Loading