feat: tests #83
Open
feat: tests #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskbx
force-pushed
the
feat/tests
branch
3 times, most recently
from
0858c37 to
0175440
Compare
kriskbx
force-pushed
the
feat/tests
branch
3 times, most recently
from
b83f92c to
17374de
Compare
kriskbx
commented
Jan 8, 2026
| process.on("unhandledRejection", (reason, promise) => { | ||
| console.error("Unhandled Rejection at: Promise", { promise, reason }); | ||
| }); | ||
| setup().then(run); |
Member
Author
There was a problem hiding this comment.
tsx doesn't support top-level await
kriskbx
force-pushed
the
feat/tests
branch
2 times, most recently
from
87f19a4 to
46878bb
Compare
kriskbx
commented
Jan 8, 2026
| export const t = transifex.t; | ||
| export const tx = transifex.tx; | ||
| export const t = transifex?.t; | ||
| export const tx = transifex?.tx; |
Member
Author
There was a problem hiding this comment.
Transifex behaves weird again. In some module resolution contexts it just resolves to undefined. For example when using tsx to run the worker. Which is not a problem right now, as we very probably don't need working translations in the worker.
kriskbx
commented
Jan 8, 2026
Comment on lines
-1
to
-2
| shamefully-hoist=true | ||
| strict-peer-dependencies=false |
Member
Author
There was a problem hiding this comment.
this was only used by bun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖊️ Description
💡 What? Why? How?
This refactors the aggregation logic into a generic aggregator, that is properly unit-tested. It also runs e2e-tests directly in the pipeline, which is faster in and allows for things like osm-sync-db seeding in the future.
It also moves from bun to node/npm and uses vitest as test runner which makes things easier. It just wasn't feasible to run the testing suite we wanted with the bun test runner.
📎 Related Ticket
https://app.asana.com/1/1200321573365931/project/1208833037492986/task/1211624818750138?focus=true
Before creating this merge request, go over the following checklist (click to expand).
Remove any items that are not applicable.
💪 I have tested my code
🧼 I have cleaned up my code
--interactiveif applicable, keeping commits in sensible chunks if possible).🔍 I have performed a self-review of my code
✨ I have created a nice pull request
📝 I updated the documentation
🔍 Reviewing
When reviewing this merge request, here are some things to keep in mind: