fix: add missing url crate and fix axum 0.8 middleware signature#146
Open
ivanhoe wants to merge 1 commit intospacedriveapp:mainfrom
Open
fix: add missing url crate and fix axum 0.8 middleware signature#146ivanhoe wants to merge 1 commit intospacedriveapp:mainfrom
ivanhoe wants to merge 1 commit intospacedriveapp:mainfrom
Conversation
browser.rs uses url::Url::parse() but the url crate was not listed in Cargo.toml, causing E0433 and cascading E0282 type inference errors. Note: the axum 0.8 middleware signature fix (State extractor) was already resolved in main.
ivanhoe
force-pushed
the
fix/compilation-errors
branch
from
51b8929 to
91d297f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
maindoes not compile cleanly after the merge of PR #117 (fix/security-hardening). Runningcargo checkon a fresh clone produces 5 errors.Errors
E0433—browser.rs:34:url::Url::parse()used but theurlcrate is not inCargo.tomlE0282—browser.rs:62,71,72: type inference failures (cascading from Add native Z.ai (GLM) provider #1)E0277—server.rs:151:api_auth_middlewaresignature incompatible with axum 0.8'sfrom_fn_with_stateFix
url = "2"toCargo.tomlapi_auth_middlewareto useState<Arc<ApiState>>extractor (required by axum 0.8)