fix(slack): Slack channel fixes, DM filtering, emoji sanitization, and restore TLS on websocket#148
Open
sra wants to merge 5 commits intospacedriveapp:mainfrom
Open
fix(slack): Slack channel fixes, DM filtering, emoji sanitization, and restore TLS on websocket#148sra wants to merge 5 commits intospacedriveapp:mainfrom
sra wants to merge 5 commits intospacedriveapp:mainfrom
Conversation
…d TLS Fixes several Slack adapter issues and restores the build after spacedriveapp#117. Build fixes: - Restore compile after security middleware changes (Axum State extractor pattern in api_auth_middleware, url::Url → reqwest::Url in browser tool) (this is from unmerged pr spacedriveapp#125) Slack DM filtering: - DMs now bypass workspace/channel filters when sender is in dm_allowed_users - dm_allowed_users is merged from both SlackConfig and per-binding configs - Added debug logging for DM permission decisions Emoji reactions: - Sanitize Slack emoji reactions to use shortcodes via the `emojis` crate - Handle edge case where emoji has no shortcode (falls back to name) - Strip colons, normalize whitespace and casing TLS connectivity: - Add tokio-tungstenite with rustls-tls-native-roots feature to fix wss:// connections that broke after the tungstenite 0.28 TLS feature restructure Logging: - Downgrade per-message Slack log from info to debug, matching Discord, Telegram, and Twitch adapters which only use info for lifecycle events Style: - Rename abbreviated `uid` to `sender_id` per style guide - Remove section-divider comments and extra blank lines in imports Tests: - 9 unit tests for sanitize_reaction_name (unicode, shortcodes, fallbacks) - 7 unit tests for SlackPermissions::from_config (merging, dedup, filtering)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d TLS
Fixes several Slack adapter issues and restores the build after #117.
Build fixes:
Slack DM filtering:
Emoji reactions:
emojiscrateTLS connectivity:
Logging:
Style:
uidtosender_idper style guideTests: