Changed HK epoch-related prints to prevent future confusion#53
Merged
Changed HK epoch-related prints to prevent future confusion#53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent issues with HK were likely caused by the manual entry of a HK time offset that was far ahead (months) of the actual HK epoch. The use of relative-time HK requests with an epoch this far off the true epoch causes confusion in the HK search algorithm, such as:
2026-01-06 14:34:44.559 15/15: No luck with block 0xF63BE36B - looking for timestamp 2209851, found 14388236, error is -12178385When manually retrieving the time offset with
hk retrieve -othe UI prints out both the current time and the epoch time. A lapse in attention of a user likely caused them to use the current time rather than the true epoch.Example of old output:
At 2026-01-07 16:15:42: Updating HK node 5804 EPOCH by 0 sec to 2025-07-23 12:46:47This simple change removes any confusion by removing the current time in the output. Both CSH and Loki logging (if enabled) has timestamps anyway. Additionally, it also prints out the epoch in its raw timestamp format (along with a human-readable ISO-formatted datetime) removing the necessity for conversion by the user if working with the times manually.
Example of new output:
HK: Updating HK node 5804 EPOCH by -10000000 sec to 2025-10-09 08:53:20 (1760000000)