Remove one unnecessary copy in csp_send_direct per call#27
Open
MErdbruegger wants to merge 1 commit intospaceinventor:masterfrom
Open
Remove one unnecessary copy in csp_send_direct per call#27MErdbruegger wants to merge 1 commit intospaceinventor:masterfrom
MErdbruegger wants to merge 1 commit intospaceinventor:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change resolves the todo left in csp_send_direct for eliminating the need to
clone the packet if it will only be sent to a single interface. This is a net neutral
in terms of stack memory usage as it replaces the int used to detect a successful
send with a new interface pointer. If the user has chosen to use the RTable it
decreases stack memory usage by one int. This also eliminates bug prone copy
and paste by using MACROs for reuse of the subnet checks and sending logic.
This comes at a slight cost of increased instruction memory usage.