Skip to content

Introduce version field in DTP transfer request/response transaction and handle mismatch. This is a *BREAKING* at the wire level#4

Open
jeanbaptistelab wants to merge 1 commit intomasterfrom
feature/introduce-version-in-network-protocol
Open

Introduce version field in DTP transfer request/response transaction and handle mismatch. This is a *BREAKING* at the wire level#4
jeanbaptistelab wants to merge 1 commit intomasterfrom
feature/introduce-version-in-network-protocol

Conversation

@jeanbaptistelab
Copy link
Contributor

No description provided.

…and handle mismatch. This is a *BREAKING* at the wire level
@troelsjessen
Copy link
Contributor

Instead of just putting a version field in the request, what about putting a min and max version supported by the client? And then add a selected version field in the response from the server.
16 bits per field should do :-)

@jeanbaptistelab
Copy link
Contributor Author

Instead of just putting a version field in the request, what about putting a min and max version supported by the client? And then add a selected version field in the response from the server. 16 bits per field should do :-)

Yes, that's an option. I choose a "uint32_t" for this field so as to not introduce packing ambiguities. As this is the first change that introduces version concept of the wire protocol, I thought that for now, it would be enough to simply bail out. When working on version 2 of the protocol, we can revisit this and implement a solution where the client can handle multiple versions ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants