Skip to content

Do not write entire file when vmem_write(), seek to correct offset instead #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeanbaptistelab merged 2 commits into from
Jan 19, 2026
Merged

Do not write entire file when vmem_write(), seek to correct offset instead #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d519356
Do not write entire file when vmem_write(), seek to correct offset in…
jeanbaptistelab Jan 19, 2026
34f8625
Remove superfluous initial seek to start
jeanbaptistelab Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/vmem/vmem_file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,12 @@ void vmem_file_init(vmem_t * vmem) {
if (fd != -1) {
driver->stream = fdopen(fd, "r+");
}
}
if(driver->stream) {
/* Read in file data if any (fread will fail if the file was just created, leaving the content of driver->physaddr alone to what it currently is) */
int read = fread(driver->physaddr, 1, vmem->size, driver->stream);
(void) read;
} else {
printf("\nWARNING: vmem[%s]: permission/path issues for associated filename: \"%s\"\n", vmem->name, driver->filename);
if(driver->stream) {
int read = fread(driver->physaddr, 1, vmem->size, driver->stream);
(void) read;
} else {
printf("\nWARNING: vmem[%s]: permission/path issues for associated filename: \"%s\"\n", vmem->name, driver->filename);
}
}
}

Expand All @@ -43,9 +42,9 @@ void vmem_file_write(vmem_t * vmem, uint64_t addr, const void * datain, uint32_t
vmem_file_init(vmem);
if(driver->stream ) {
/* Flush back to file */
int res = fseek(driver->stream, 0, SEEK_SET);
int res = fseek(driver->stream, addr, SEEK_SET);
(void)res;
int written = fwrite(driver->physaddr, 1, vmem->size, driver->stream);
int written = fwrite(driver->physaddr + addr, len, 1, driver->stream);
fflush(driver->stream);
(void) written;
}
Expand Down
Loading