Skip to content

Conversation

@wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Dec 29, 2025

This PR marks explicit conflicts between podio, edm4hep, and dd4hep and ^python +freethreading. To be resolved in next releases (AIDASoft/podio#911, key4hep/EDM4hep#469, AIDASoft/DD4hep#1547).

@wdconinc wdconinc changed the title podio: conflicts ^python +freethreading podio, edm4hep: conflicts ^python +freethreading Dec 29, 2025
Add conflict for python free-threading requirement.
@wdconinc wdconinc marked this pull request as ready for review December 29, 2025 21:04
Copilot AI review requested due to automatic review settings December 29, 2025 21:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds explicit conflicts between the podio and edm4hep packages and Python with free-threading enabled (^python +freethreading). These conflicts prevent incompatible combinations until future releases of these packages add support for Python free-threading.

  • Adds conflict declaration for podio@:1.6 with ^python +freethreading, requiring version 1.7 or later
  • Adds conflict declaration for edm4hep@:0.99.4 with ^python +freethreading, requiring version 0.99.5 or later

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
repos/spack_repo/builtin/packages/podio/package.py Adds conflict preventing podio versions up to 1.6 from being used with Python free-threading
repos/spack_repo/builtin/packages/edm4hep/package.py Adds conflict preventing edm4hep versions up to 0.99.4 from being used with Python free-threading

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

wdconinc and others added 3 commits December 29, 2025 20:52
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Reformat conflict statement for better readability.
@wdconinc wdconinc changed the title podio, edm4hep: conflicts ^python +freethreading podio, edm4hep, dd4hep: conflicts ^python +freethreading Dec 31, 2025
@alalazo alalazo merged commit 7e4068a into develop Jan 7, 2026
17 checks passed
@alalazo alalazo deleted the podio-edm4hep-python-freethreading branch January 7, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants