Open
Conversation
spajic
approved these changes
Mar 15, 2019
Owner
spajic
left a comment
spajic
left a comment
There was a problem hiding this comment.
Очень хорошая работа!
Особый респект за MiniTest::Benchmark и ассерт линейной асимптотики.
Плюс несколько комментов по ходу.
| require 'minitest/autorun' | ||
| require './task-1' | ||
|
|
||
| class BenchTest < MiniTest::Benchmark |
| end | ||
|
|
||
| def bench_algorithm | ||
| assert_performance_linear 0.9999 do |n| |
| end | ||
| end | ||
|
|
||
| def algorithm(lines_num) |
| Аллоцируется 400 Mb объектов класса Array и 16 Mb класса String. | ||
| Более всего памяти для класса Array выделяется в строках 53, 54, 100, 102. | ||
| Более всего памяти для класса String выделяется в строках 39,46, 52, 139, 142. | ||
| Аллоцируются одинаковые строки `" ", "session", ",", "user"` |
Owner
There was a problem hiding this comment.
Case-study лучше читается, когда в этом же блоке сразу и результат.
|
|
||
| ## Результаты | ||
| В результате проделанной оптимизации наконец удалось обработать файл с данными. | ||
| Удалось улучшить метрику системы |
Owner
There was a problem hiding this comment.
Хорошо бы указать с какого до какого значения.
|
|
||
| ## Защита от регресса производительности | ||
| Для защиты от потери достигнутого прогресса при дальнейших изменениях программы | ||
| написан тест `bench_test.rb`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.