Open
Conversation
spajic
approved these changes
Apr 24, 2019
Owner
spajic
left a comment
spajic
left a comment
There was a problem hiding this comment.
Nice work! 👍
Some comments in review
| ) | ||
|
|
||
| IO.foreach("#{$support_dir}/#{filename}") do |cols| | ||
| row = cols.split(',') |
Owner
There was a problem hiding this comment.
Можно было бы ещё читать строку посимвольно, чтобы обойтись без split
| IO.foreach("#{$support_dir}/#{filename}") do |cols| | ||
| row = cols.split(',') | ||
|
|
||
| if cols.start_with?('user') |
Owner
There was a problem hiding this comment.
Вот тут бы мы тогда при встрече с первой запятой посмотрели, что накопили в аккумуляторе и избежали start_with
|
|
||
| %self total self wait child calls name | ||
| 23.11 0.018 0.004 0.000 0.013 1 <Class::IO>#foreach | ||
| 12.59 0.003 0.002 0.000 0.001 264 <Module::Oj>#dump |
Owner
There was a problem hiding this comment.
Без dump в принципе можно тоже было бы обойтись, дописывать json потоково просто
| require 'benchmark/ips' | ||
| require 'yaml' | ||
|
|
||
| metrics, = Benchmark.ips do |bench| |
Author
There was a problem hiding this comment.
data тут возвращает массив с одним элементом, деструктуризировал хэш сразу :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.