Skip to content

task-2#8

Open
one0fnine wants to merge 1 commit intospajic:masterfrom
one0fnine:master
Open

task-2#8
one0fnine wants to merge 1 commit intospajic:masterfrom
one0fnine:master

Conversation

@one0fnine
Copy link

No description provided.

Copy link
Owner

@spajic spajic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень хорошая работа, спасибо!
И респект за valgrind в докере! Вы первый такое сделали.

.repl_history
build/
*.bridgesupport
build-iPhoneOS/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ого

Total memory for date_large.1.txt: 74 MB
```

Статистика по ***memory_profilter***
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Опечатка profilter -> profiler

* Array#map - 16.33%

Чтобы понимать причину возникновения утечки памяти с *Array#each* все части кода,
где используется этот метод, я вынесу в отдельные методы. После чего по отчету становится
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -0,0 +1,4 @@
#!/bin/bash

valgrind --tool=massif --massif-out-file=./massif.out ruby massif.rb && \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

after = `ps -o rss= -p #{Process.pid}`.to_i
puts "Memory usage: #{result = (after - before) / 1024} MB"

assert result <= TOP_ALLOCATED_MEMORY + ERROR_ALLOCATED_MEMORY
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants