Skip to content

Optimize json import#4

Open
pustserg wants to merge 1 commit intospajic:masterfrom
pustserg:optimize
Open

Optimize json import#4
pustserg wants to merge 1 commit intospajic:masterfrom
pustserg:optimize

Conversation

@pustserg
Copy link

@pustserg pustserg commented Apr 5, 2019

No description provided.

Copy link
Owner

@spajic spajic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По оптимизации импорта - аппрув.
Но ещё надо оптимизировать вывод страницы, поэтому PR пока не апрувлю.

@@ -1 +1 @@
2.6.1
2.6.2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

gem 'byebug', platforms: [:mri, :mingw, :x64_mingw]
gem 'benchmark-ips'
gem 'ruby-prof'
gem 'pghero'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

gem 'benchmark-ips'
gem 'ruby-prof'
gem 'pghero'
gem 'pg_query', '>= 0.9.0'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


Время работы сейчас важнее потребляемой памяти, попробую не делать на каждую строку find_or_create, а сделать массив и вставить c помощью bulk_insert

Стало намного лучше
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants