Open
Conversation
spajic
requested changes
Apr 14, 2019
Owner
spajic
left a comment
There was a problem hiding this comment.
Добавлю разъяснения по сдаче задания в описание.
| @@ -0,0 +1,16 @@ | |||
| Мединана полной загрузки (Load Time) страницы для версии: | |||
|
|
|||
| без пуша и без инлайна: 21.239s https://www.webpagetest.org/result/190413_X6_b19cc6cd03c2675c0aecae9be10d4e95/ | |||
Owner
There was a problem hiding this comment.
Все результаты не совсем корректны, потому что работа идёт по протоколу HTTP/1.1.
Поэтому server-push на самом деле не может работать.
Добавлю разъяснения в описание задания.
results.md
Outdated
|
|
||
| Видно что при инлайниге к картинкам вообще не делается запрос, а при сервер пуш они начинают загружаться сразу после загрузки главной страницы. | ||
|
|
||
| Проблемы обнаруженые при аудите: |
Owner
There was a problem hiding this comment.
Это для продового dev.to или для ngrok?
Author
There was a problem hiding this comment.
Да я локально запускал, не очевидно было в задании
results.md
Outdated
| * Отсутствие GZip сжатия для JS-ассетов | ||
| * Отсутствие заголовков max-age or expires для статического контента | ||
|
|
||
| Таже возникли некоторые инсайты и проблемы описанные здесь http://connect.thinknetica.com/t/aleksandr-emelyanov-ketzer/7548/32 (кажется кто-то наши отёты не читает ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.