Skip to content

TASK-6#7

Open
one0fnine wants to merge 2 commits intospajic:masterfrom
one0fnine:master
Open

TASK-6#7
one0fnine wants to merge 2 commits intospajic:masterfrom
one0fnine:master

Conversation

@one0fnine
Copy link

Webpacker analyze

before:
Screenshot 2019-05-18 at 21 24 50
after:
Screenshot 2019-05-18 at 21 29 55

SiteSpeed

https://compare.sitespeed.io/?har1=https://gist.githubusercontent.com/one0fnine/1c66f2773d71faf22cf3858c02adcbd0/raw/31d22c4ee2fbfb64973d0d26059d1277603aa1e7/origin.har&har2=https://gist.githubusercontent.com/one0fnine/1c66f2773d71faf22cf3858c02adcbd0/raw/31d22c4ee2fbfb64973d0d26059d1277603aa1e7/without.har&compare=1

В целом конечно этот пакет проблемный, и используется только в одном месте сайта (на странице dashboard/pro). По-этому, как вариант, можно использовать lazy-loading и убрать его в отдельный chunk для сборки webpacker-a

Copy link
Owner

@spajic spajic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Всё супер

@@ -0,0 +1,49 @@
FROM alpine:latest

LABEL Alec Pervushin <alec.for.public@gmail.com>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice email 👍

const [
reactionsChart,
commentsChart,
] = import(/* webpackChunkName: 'moment' */ 'chart.js').then(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants