Open
Conversation
Collaborator
|
Thanks for the suggestion. A little nitpick that the On a broader scope, I've taken a look at https://github.com/Dansoftowner/jSystemThemeDetector and it seems there's more than one approach. I'm not particularly keen to add all the dependencies that project has for such a simple function, but it's worth considering the techniques used there. I think I'd want to put in more work into the dark theme before merging this. Specifically, there are images that require SVG alternatives so they can be properly colour inverted in dark mode. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve added a "System Default" theme option that reads the system theme and applies it to Sparrow (switching between Light and Dark) at startup. This change ensures Sparrow launches with the same theme as the user’s system preference.
Changes Made:
detectSystemThememethod to identify the system theme.isMacDarkModeto check theAppleInterfaceStylesetting on macOS.Limitations:
Future Steps: