GHA package.yaml: Add explicit job name#1656
Open
msgilligan wants to merge 1 commit intosparrowwallet:masterfrom
Open
GHA package.yaml: Add explicit job name#1656msgilligan wants to merge 1 commit intosparrowwallet:masterfrom
msgilligan wants to merge 1 commit intosparrowwallet:masterfrom
Conversation
Collaborator
|
While I acknowledge Wrt the OS name, it appears Github adds this automatically if it's not explicitly set: 
I don't have problem with explicitly naming the job though. Can I suggest instead: jobs:
build:
name: build (${{ matrix.os }}) |
* Add a `name` attribute setting job name with matrix.os This matches the format of `nix-jpackage.yaml` in PR sparrowwallet#1648 to keep them similar assuming both PRs are merged as is.
msgilligan
force-pushed
the
msgilligan/gha-package-minor-tweaks
branch
from
4673de4 to
36662e1
Compare
msgilligan
changed the title
Contributor
Author
@craigraw Done. Rebased and force-pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change job label frombuildtojpackagenameattribute setting name with matrix.osThis matches the format of
package-nix.yamlin PR #1648 to keep them similar assuming it is merged as is.