fix(CrawlUrl): Use before initialization is now impossible #490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, it was possible to call
\Spatie\Crawler\CrawlUrl::getIdon an object with an uninitializedîdproperty:This is because
$idis type-annotated withmixed(which is the default any way) and the PHP manual says:This PR fixes this issue
PS: It also introduces a minimally usable devcontainer configuration for Github codespaces and the like, this can be cherrypicked out