Skip to content

Conversation

@kwhuber
Copy link
Contributor

@kwhuber kwhuber commented Jan 11, 2026

Fixes #4988

This PR introduces a change to fix a ui issue when a user deletes records through the query builder. Before the change, after deleting the last record in a specific query, the results header would incorrectly return as Results: (-1). After the change, the results header will only show Results: (0) when the last record is deleted.

This change is in the following line:

totalCount === undefined ? undefined : Math.max(0, totalCount - removeCount)

This prevents a negative account from showing up in the results header.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Create a query (or use existing one)
  • Delete all the records that show up
  • Verify that the results count is zero and non-negative

@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Jan 11, 2026
@kwhuber kwhuber requested a review from a team January 11, 2026 22:38
@kwhuber kwhuber added this to the 7.12.0 milestone Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

Querying and deleting all results makes the results show as -1

2 participants