Skip to content

Raise if parameter_type_list doesn't contain unique types #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soininen merged 1 commit into from
Dec 11, 2025
Merged

Raise if parameter_type_list doesn't contain unique types #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion spinedb_api/mapped_items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,7 +814,12 @@ class ParameterDefinitionItem(ParameterItemBase):

def __init__(self, db_map, **kwargs):
super().__init__(db_map, **kwargs)
self._init_type_list = kwargs.get("parameter_type_list")
if "parameter_type_list" in kwargs:
self._init_type_list = kwargs["parameter_type_list"]
if len(set(self._init_type_list)) != len(self._init_type_list):
raise SpineDBAPIError("entries in parameter_type_list must be unique")
else:
self._init_type_list = None

def __getitem__(self, key):
if key == "parameter_type_id_list":
Expand Down
12 changes: 12 additions & 0 deletions tests/test_DatabaseMapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3521,6 +3521,18 @@ def test_changing_value_list_while_values_exist_is_disallowed(self):
):
lungs.update(parameter_value_list_id=values2["id"])

def test_adding_parameter_definition_with_duplicate_type_raises(self):
with DatabaseMapping("sqlite://", create=True) as db_map:
db_map.add_entity_class(name="sea_monster")
with self.assertRaisesRegex(SpineDBAPIError, "^entries in parameter_type_list must be unique$"):
db_map.add_parameter_definition(
entity_class_name="sea_monster", name="reputation", parameter_type_list=("float", "float")
)
self.assertEqual(db_map.find_parameter_definitions(), [])
horror_factor = db_map.add_parameter_definition(entity_class_name="sea_monster", name="horror_factor")
with self.assertRaisesRegex(SpineDBAPIError, "^entries in parameter_type_list must be unique$"):
horror_factor.update(parameter_type_list=("str", "str"))


class TestDatabaseMappingLegacy(unittest.TestCase):
"""'Backward compatibility' tests, i.e. pre-entity tests converted to work with the entity structure."""
Expand Down