Detect dirty git repo #4
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cool little gradle plugin has one issue in case the git repo is dirty, meaning has unstaged or uncommitted changes.
The branch name and short commit hash on the app icon is not indicating if the the repo was dirty when compiling so you can't really rely on the information when giving the debug build to someone. It might have some unknown changes compiled in this build or not.
I suggest to detect if git repo is dirty and show it with different text colour, e.g. red. Of course other visualizations would be possible e.g. $branch\n$commit\n(dirty), but i leave this for discussion.
The implementation provides a flag to enable/disable the dirty check (disabled by default, could be enabled by default?).