Update #42
Open
Update #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to make parcelable implementations optional on NavigationKey and allowing kotlinx serialization for NavigationKeys
…aries; lots of hacky code here, needs to be cleaned up
…ion and hold ActivityNavigationContainers
…ras as a type to handle serializing extras for instructions, but this needs to be cleaned up a bit
…o be serialized, using a polymorphic Any serializer registered on the NavigationController
… container, added TODO to get ActivityNavigationContainer saving correctly
…he common source set
…d made tweaks to plugins/context/execute instruction functionality to support this
… for the DesktopWindow destination type
… up and moved around some extension functions
… this appears to cause compilation failures
…s and ensure processing completes correctly
…ommon definitions of classes which may be required by targets that do not display UI (e.g. NodeJS backends)
…ll TODOs for now)
…classes, and added the ability to parse these paths into NavigationKeys
# Conflicts: # enro-common/src/commonMain/kotlin/dev/enro/path/NavigationContext.getNavigationKeyFromPath.kt
…ausing issues with git submodules and gradle composite builds)
…o currentCompositeHash in the recent Compose updates
…rching for a specific destination or container
…hen the generated bindings were defined in external modules/libraries
…also properly apply, add basic implementation for wasmJs functionality
…ation component and no navigation destinations wouldn't correctly read all navigation destinations from other modules in the project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.