Skip to content

Fix test assertion for paginated results #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michael-burt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix test assertion for paginated results #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/remote/query_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,6 @@ func TestListPagination(t *testing.T) {
actual := len(objs)
if int(totalItemsInList) != actual {
t.Logf("expected items to be %d but found %d. Change this to Fatal when https://github.com/kubernetes/kubernetes/issues/107277 is fixed", totalItemsInList, actual)
// t.Fatalf("expected items to be %d but found %d", totalItemsInList, actual)
t.Fatalf("expected items to be %d but found %d", totalItemsInList, actual)
}
}
Loading