feat: pass Decodable struct to flag evaluation#191
Draft
Conversation
rokridi
reviewed
Nov 20, 2025
There was a problem hiding this comment.
I think that func asJSONData() -> Data? could be rewritten like this:
public extension ConfidenceValue {
func asJSONData() -> Data? {
return try? JSONSerialization.data(withJSONObject: self.value.jsonValue)
}
}
extension ConfidenceValueInternal {
var jsonValue: Any {
return switch self {
case .boolean(let bool):
bool
case .string(let string):
string
case .integer(let int):
int
case .double(let double):
double
case .date(let dateComponents):
dateComponents
case .timestamp(let date):
date
case .list(let array):
array.map(\.jsonValue)
case .structure(let dictionary):
dictionary.mapValues(\.jsonValue)
case .null:
NSNull()
}
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
a significant enhancement to the Confidence SDK for Swift by adding support for passing Decodable structs directly to flag evaluation. The main changes include:
API Methods:
getEvaluation<T: Decodable>(key: String, defaultValue: T)method that allows passing a Codable struct as contextgetValue<T: Decodable>(key: String, defaultValue: T)method for direct value retrieval with contextType Safety:
This provides better compile-time checking and IDE support compared to the dictionary-based approach
Backward Compatibility:
All existing methods continue to work as before since ConfidenceValue's are Codeable.
This enhancement makes the SDK more Swift-idiomatic by:
The changes are particularly useful for developers who want to:
Open questions