Move fabric8 discovery to listers#2133
Draft
wind57 wants to merge 31 commits intospring-cloud:mainfrom
Draft
Conversation
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
wind57
commented
Feb 5, 2026
| } | ||
|
|
||
| @Bean | ||
| @ConditionalOnMissingBean |
Contributor
Author
There was a problem hiding this comment.
we used to create this one in place where needed, but then I noticed that in the k8s-client native, we create in the auto-configuration. So I decided to do it in the fabric8 case too.
Also, it simplifies testing a lot, having it as a Bean
wind57
commented
Feb 5, 2026
| LogFactory.getLog(Fabric8AbstractBlockingDiscoveryClient.class)); | ||
|
|
||
| private final KubernetesDiscoveryProperties properties; | ||
| private final List<Lister<Service>> serviceListers; |
Contributor
Author
There was a problem hiding this comment.
Listers and Informers here, just like the case for the k8s-native client. Unlike the native client, we don't have to deal with SharedInfomerFactory, so a bit simpler
wind57
commented
Feb 5, 2026
|
|
||
| List<Endpoints> allEndpoints = endpoints(properties, client, namespaceProvider, "fabric8-discovery", serviceId, | ||
| predicate); | ||
| List<Service> allServices = serviceListers.stream() |
Contributor
Author
There was a problem hiding this comment.
this is a 1-1 mapping with k8s-native, meaning we do things the same here, much easier to reason like this
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.