Fix GrpcClientRegistrationSpec#packageClasses#364
Merged
onobc merged 1 commit intospring-projects:1.0.xfrom Jan 28, 2026
Merged
Fix GrpcClientRegistrationSpec#packageClasses#364onobc merged 1 commit intospring-projects:1.0.xfrom
GrpcClientRegistrationSpec#packageClasses#364onobc merged 1 commit intospring-projects:1.0.xfrom
Conversation
onobc
commented
Jan 28, 2026
spring-grpc-core/src/test/java/org/springframework/grpc/client/GrpcClientFactoryTests.java
Outdated
Show resolved
Hide resolved
onobc
commented
Jan 28, 2026
spring-grpc-core/src/main/java/org/springframework/grpc/client/GrpcClientFactory.java
Show resolved
Hide resolved
onobc
force-pushed
the
GH-361-grpc-reg-spec-loop-fix
branch
from
1400b9e to
1cd73df
Compare
Fixes the `packageClasses` method so that it does not overwrite the other packages. If you pass in A.class and B.class (from separate packages) a string array w/ each class base package string is now returned. Fixes spring-projects#361 Signed-off-by: onobc <chris.bono@gmail.com>
onobc
force-pushed
the
GH-361-grpc-reg-spec-loop-fix
branch
from
1cd73df to
5541007
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
packageClassesmethod so that it does not overwrite the other packages. If you pass in A.class and B.class (from separate packages) a string array w/ each class base package string is now returned.Fixes #361
@PARKPARKWOO PTAL