Do not re-fetch security context in auth interceptor #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `AuthenticationProcessInterceptor` the security context was being re-fetched from the holder. While this should not cause any issues, it was surfacing an issue in a user's custom service that is using the context propagation library. While this is somewhat of a workaround, the re-fetch should not be necessary and it unblocks the user from upgrading from Spring gRPC 0.7.0 to 1.0.x. See spring-projects#360 Signed-off-by: onobc <chris.bono@gmail.com>
onobc
added
the
for: port-to-1.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
AuthenticationProcessInterceptorthe security context was being re-fetched from the holder. While this should not cause any issues, it was surfacing an issue in a user's custom service that is using the context propagation library. While this is somewhat of a workaround, the re-fetch should not be necessary and it unblocks the user from upgrading from Spring gRPC 0.7.0 to 1.0.x.See #360