Skip to content

Comments

Fix longName defaulting to parameter name when not provided #1261#1303

Closed
czpilar wants to merge 1 commit intospring-projects:mainfrom
czpilar:patches/1261-long-name
Closed

Fix longName defaulting to parameter name when not provided #1261#1303
czpilar wants to merge 1 commit intospring-projects:mainfrom
czpilar:patches/1261-long-name

Conversation

@czpilar
Copy link
Contributor

@czpilar czpilar commented Jan 29, 2026

Resolves #1261

@czpilar czpilar mentioned this pull request Jan 29, 2026
Closed
@fmbenhassine
Copy link
Contributor

fmbenhassine commented Jan 30, 2026

I was working on this as well and had almost the same change set!

gh1261.patch

LGTM 👍 Rebased and merged as 6b1e701.

Thank you for your contribution!

@czpilar
Copy link
Contributor Author

czpilar commented Jan 30, 2026

Yes, that is unfortunate - both of us working on the same problem. I wasn’t sure whether you had already started on this, but since the 4.0.1 release is planned for today, I took a look at it.

Moreover, I fixed the option proposal in CommandCompleter when the longName of an option is empty, as it was proposing --. After fixing the default value of longName, however, the empty value should no longer occur.

@czpilar czpilar deleted the patches/1261-long-name branch January 30, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Commands fail in 4.0 if no short name or long name are specified

2 participants

@czpilar @fmbenhassine